mapleFU commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r2158122006
##########
cpp/src/parquet/CMakeLists.txt:
##########
@@ -159,6 +159,8 @@ set(PARQUET_SRCS
arrow/variant_internal.cc
arrow/writer.cc
bloom_filter.cc
+ bloom_filter_builder_internal.cc
+ bloom_filter_writer_internal.cc
Review Comment:
> It's confusing to have both "builder" and "writer" APIs
1. `builder` is used in creating the column writer, and be created and hold
in file level
2. `writer` is just a helper for `column_writer.cc`
Do you have better idea for this? I don't want `writer` exposed to file
level api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
