kou commented on code in PR #46834:
URL: https://github.com/apache/arrow/pull/46834#discussion_r2158335237
##########
ci/conan/all/test_package/CMakeLists.txt:
##########
@@ -20,7 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
-cmake_minimum_required(VERSION 3.15)
+cmake_minimum_required(VERSION 3.25)
Review Comment:
Ditto.
##########
ci/conan/all/conanfile.py:
##########
@@ -268,7 +268,9 @@ def validate(self):
raise ConanInvalidConfiguration("arrow:parquet requires
arrow:with_thrift")
def build_requirements(self):
- if Version(self.version) >= "13.0.0":
+ if Version(self.version) >= "20.0.0":
+ self.tool_requires("cmake/[>=3.25 <4]")
+ else:
Review Comment:
Could you keep `ci/conan/**` files untouched?
`ci/conan/**` files are synchronized by `ci/conan/merge_upstream.sh` from
upstream. If we change `ci/conan/**` in apache/arrow, the merge script may
report many conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
