kou commented on code in PR #46842:
URL: https://github.com/apache/arrow/pull/46842#discussion_r2158404407
##########
cpp/src/gandiva/precompiled/time_test.cc:
##########
@@ -363,6 +363,46 @@ TEST(TestTime, TimeStampTrunc) {
StringToTimestamp("2000-02-28 00:00:00"));
EXPECT_EQ(date_trunc_Week_timestamp(StringToTimestamp("2000-03-06
10:10:10")),
StringToTimestamp("2000-03-06 00:00:00"));
+
+ // Test dates before epoch (1970-01-01)
+ EXPECT_EQ(date_trunc_Second_date64(StringToTimestamp("1969-12-31 23:45:15")),
+ StringToTimestamp("1969-12-31 23:45:15"));
+ EXPECT_EQ(date_trunc_Minute_date64(StringToTimestamp("1969-12-31 23:45:15")),
+ StringToTimestamp("1969-12-31 23:45:00"));
+ EXPECT_EQ(date_trunc_Hour_date64(StringToTimestamp("1969-12-31 23:45:15")),
+ StringToTimestamp("1969-12-31 23:00:00"));
+ EXPECT_EQ(date_trunc_Day_date64(StringToTimestamp("1969-12-31 23:45:15")),
+ StringToTimestamp("1969-12-31 00:00:00"));
+ EXPECT_EQ(date_trunc_Month_date64(StringToTimestamp("1969-12-31 23:45:15")),
+ StringToTimestamp("1969-12-01 00:00:00"));
+ EXPECT_EQ(date_trunc_Quarter_date64(StringToTimestamp("1969-12-31
23:45:15")),
+ StringToTimestamp("1969-10-01 00:00:00"));
+ EXPECT_EQ(date_trunc_Year_date64(StringToTimestamp("1969-12-31 23:45:15")),
+ StringToTimestamp("1969-01-01 00:00:00"));
+ EXPECT_EQ(date_trunc_Decade_date64(StringToTimestamp("1969-12-31 23:45:15")),
+ StringToTimestamp("1960-01-01 00:00:00"));
+
+ // Test date further in the past
+ EXPECT_EQ(date_trunc_Second_date64(StringToTimestamp("1930-05-15 12:34:56")),
+ StringToTimestamp("1930-05-15 12:34:56"));
+ EXPECT_EQ(date_trunc_Minute_date64(StringToTimestamp("1930-05-15 12:34:56")),
+ StringToTimestamp("1930-05-15 12:34:00"));
+ EXPECT_EQ(date_trunc_Hour_date64(StringToTimestamp("1930-05-15 12:34:56")),
+ StringToTimestamp("1930-05-15 12:00:00"));
+ EXPECT_EQ(date_trunc_Day_date64(StringToTimestamp("1930-05-15 12:34:56")),
+ StringToTimestamp("1930-05-15 00:00:00"));
+ EXPECT_EQ(date_trunc_Day_date64(StringToTimestamp("1940-02-29 12:00:00")),
+ StringToTimestamp("1940-02-29 00:00:00"));
+ EXPECT_EQ(date_trunc_Month_date64(StringToTimestamp("1930-05-15 12:34:56")),
+ StringToTimestamp("1930-05-01 00:00:00"));
+ EXPECT_EQ(date_trunc_Quarter_date64(StringToTimestamp("1930-05-15
12:34:56")),
+ StringToTimestamp("1930-04-01 00:00:00"));
+ EXPECT_EQ(date_trunc_Year_date64(StringToTimestamp("1930-05-15 12:34:56")),
+ StringToTimestamp("1930-01-01 00:00:00"));
+ EXPECT_EQ(date_trunc_Decade_date64(StringToTimestamp("1930-05-15 12:34:56")),
+ StringToTimestamp("1930-01-01 00:00:00"));
Review Comment:
Can we use other year like `1931` here to distinct "Year" and "Decade" case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
