alamb commented on issue #7700: URL: https://github.com/apache/arrow-rs/issues/7700#issuecomment-2991383840
> I have a change [here](https://github.com/apache/arrow-rs/commit/9f58e893eacd7c16518f4ba7192af580b55dfadd#diff-19c7b0b0d73ef11489af7932f49046a19ec7790896a8960add5a3ded21d5657aR762) which splits the append_string function into append_string and append_short_string and moves the length check directly into append_value. Is this the sort of change you were thinking about for this issue, or is there some way we could avoid checking the string length more than once here? I agree with @scovich this is the kind of change that was envisioned -- maybe you can get that up as a PR and we can merge it in and follow up with better validation for short string later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
