scovich commented on code in PR #7717:
URL: https://github.com/apache/arrow-rs/pull/7717#discussion_r2158937153


##########
parquet-variant/src/decoder.rs:
##########
@@ -98,7 +98,7 @@ impl TryFrom<u8> for VariantPrimitiveType {
     }
 }
 
-/// The number of bytes used to store offsets in the [`VariantMetadataHeader`]
+/// The number of bytes used to store offsets in the `VariantMetadataHeader`

Review Comment:
   This is not quite accurate. Suggest this instead?
   ```suggestion
   /// Used to unpack offset array entries such as metadata dictionary offsets 
or object/array value
   /// offsets. Also used to unpack object field ids. These are always derived 
from a two-bit
   /// `XXX_size_minus_one` field in the corresponding header byte.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to