alamb commented on a change in pull request #9865:
URL: https://github.com/apache/arrow/pull/9865#discussion_r610142533
##########
File path: rust/datafusion/tests/user_defined_plan.rs
##########
@@ -471,12 +471,10 @@ impl Stream for TopKReader {
return Poll::Ready(None);
}
// this aggregates and thus returns a single RecordBatch.
- self.done = true;
Review comment:
this is probably a real bug -- the topK isn't actually done until it
produces output -- and the way this code is written
`top_values.poll_next_unpin()` may not return `Poll::NotReady` ? Maybe?
Anyhow, looks great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
