comphead commented on PR #7726: URL: https://github.com/apache/arrow-rs/pull/7726#issuecomment-2993684451
> Thank you @comphead -- i think we should add a test for this > > i tried to make some tests in `take` as that uses mutable array data ( > > https://github.com/apache/arrow-rs/blob/f92ff183aad326b1a818f6495215f60b27d9ad4b/arrow-select/src/take.rs#L2057-L2066 > > I asserted that the output array had no nulls > > However, that test passes without this change so I probably don't understand the case that can cause the problem Thanks @alamb I'm adding the test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
