Dandandan commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160322025
##########
arrow-ord/src/cmp.rs:
##########
@@ -566,12 +566,18 @@ impl<'a, T: ByteViewType> ArrayOrd for &'a
GenericByteViewArray<T> {
type Item = (&'a GenericByteViewArray<T>, usize);
fn is_eq(l: Self::Item, r: Self::Item) -> bool {
+ let l_view = unsafe { l.0.views().get_unchecked(l.1) };
+ let r_view = unsafe { r.0.views().get_unchecked(r.1) };
+ if l.0.data_buffers().is_empty() && r.0.data_buffers().is_empty() {
Review Comment:
I think the code probably depends on inlining / moving this check outside of
the loop?
Should we add `#[inline(always)]` to it to make sure it keeps doing that? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
