adriangb commented on code in PR #7737:
URL: https://github.com/apache/arrow-rs/pull/7737#discussion_r2160358275
##########
arrow-arith/src/numeric.rs:
##########
@@ -510,49 +510,122 @@ fn timestamp_op<T: TimestampOp>(
}
/// Arithmetic trait for date arrays
-///
-/// Note: these should be fallible (#4456)
trait DateOp: ArrowTemporalType {
Review Comment:
I felt that it was better to just break this trait than introduce all of the
new methods. It should be pretty easy for users to update the trait
implementation itself, and it's always possible for them to just `.expect(...)`
in their code to at least acknowledge the fallibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
