friendlymatthew opened a new pull request, #7741: URL: https://github.com/apache/arrow-rs/pull/7741
# Which issue does this PR close? - Closes https://github.com/apache/arrow-rs/issues/7730 This PR was based off of a prior commit #7720. This PR starts from the second commit. # Rationale for this change This commit changes the function name `ObjectBuilder::append_value` to `ObjectBuilder::insert`. It also performs a validation check upon every `insert` call to check whether a duplicate field name exists for that object. The Parquet Variant spec states: > Field names are case-sensitive. Field names are required to be unique for each object. It is an error for an object to contain two fields with the same name, whether or not they have distinct dictionary IDs. I took this literally, meaning the `insert` call will err. However, I'm starting to think this API design is not ergonomic, rather the second `insert` call with the duplicate field name should simply update the value-- similar to how the std::HashMap works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
