zeroshade opened a new pull request, #3009:
URL: https://github.com/apache/arrow-adbc/pull/3009
Looks like the changes and update for the Otel infrastructure introduced a
mismatch with how the interface for ExecuteSchema is handled. As a result we
have a failing test:
```
=== RUN TestSnowflake/TestDescribeOnly
iface.go:102: test panicked: interface conversion: *driverbase.statement
is not adbc.StatementExecuteSchema: missing method ExecuteSchema
goroutine 1970 [running]:
runtime/debug.Stack()
/Users/runner/hostedtoolcache/go/1.24.1/arm64/src/runtime/debug/stack.go:26
+0x64
github.com/stretchr/testify/suite.failOnPanic(0x14000107880,
{0x106511f00, 0x14000ae0e70})
/Users/runner/go/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:89
+0x38
github.com/stretchr/testify/suite.Run.func1.1()
/Users/runner/go/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:188
+0x22c
panic({0x106511f00?, 0x14000ae0e70?})
/Users/runner/hostedtoolcache/go/1.24.1/arm64/src/runtime/panic.go:792 +0x124
github.com/apache/arrow-adbc/go/adbc/driver/snowflake_test.(*SnowflakeTests).TestDescribeOnly(0x14000516a00)
/Users/runner/work/arrow-adbc/arrow-adbc/go/adbc/driver/snowflake/driver_test.go:2043
+0x120
reflect.Value.call({0x140004aed00?, 0x1400028f848?, 0x14000863d78?},
{0x1060536fa, 0x4}, {0x14000863f20, 0x1, 0x105faf274?})
/Users/runner/hostedtoolcache/go/1.24.1/arm64/src/reflect/value.go:584 +0x978
reflect.Value.Call({0x140004aed00?, 0x1400028f848?, 0x66a?},
{0x14000863f20?, 0x1071eb558?, 0x107632b60?})
/Users/runner/hostedtoolcache/go/1.24.1/arm64/src/reflect/value.go:368 +0x94
github.com/stretchr/testify/suite.Run.func1(0x14000107880)
/Users/runner/go/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:202
+0x394
testing.tRunner(0x14000107880, 0x140001b4870)
/Users/runner/hostedtoolcache/go/1.24.1/arm64/src/testing/testing.go:1792 +0xe4
created by testing.(*T).Run in goroutine 1055
/Users/runner/hostedtoolcache/go/1.24.1/arm64/src/testing/testing.go:1851 +0x374
```
This change updates the interface definition to fix the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
