toddmeng-db commented on code in PR #3014:
URL: https://github.com/apache/arrow-adbc/pull/3014#discussion_r2162671339
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -319,21 +318,16 @@ internal override IArrowArrayStream NewReader<T>(T
statement, Schema schema, TGe
throw new InvalidOperationException("Cannot obtain a reader
for Databricks");
}
- if (metadataResp != null)
+ if (metadataResp != null && metadataResp.__isset.lz4Compressed)
{
- if (metadataResp.__isset.resultFormat)
- {
- resultFormat = metadataResp.ResultFormat;
- }
-
- if (metadataResp.__isset.lz4Compressed)
- {
- isLz4Compressed = metadataResp.Lz4Compressed;
- }
+ isLz4Compressed = metadataResp.Lz4Compressed;
}
- // Choose the appropriate reader based on the result format
- if (resultFormat == TSparkRowSetType.URL_BASED_SET)
+ // Inspect direct results to determine if result links are
available (similar to JDBC driver)
+ bool hasResultLinks =
HasResultLinks(databricksStatement.DirectResults);
+
Review Comment:
I think we don't need to worry about databricksStatement.DirectResults
changing due to race conditions, since I believe DatabricksStatement is only
used in parallel by DatabricksOperationStatusPoller, which does not use any
function that changes the DatabricksStatement state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
