alamb opened a new pull request, #7770: URL: https://github.com/apache/arrow-rs/pull/7770
# Which issue does this PR close? We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. - part of https://github.com/apache/arrow-rs/issues/6736 # Rationale for this change I noticed this while reviewing @Weijun-H's PR - https://github.com/apache/arrow-rs/pull/7738 I didn't know what part of the crate were using the fields directly and thus what part could potentially be creating invalid variants. By making the fields non `pub(crate)` I think it makes it clear these can not be constructed invalidly This also gave me a good excuse to write some more examples # What changes are included in this PR? 1. make fields in `VariantDecimal*` private 2. Add doc examples examples # Are these changes tested? By CI # Are there any user-facing changes? API change in a non-published crate, so no end user impact yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
