alamb commented on code in PR #7771:
URL: https://github.com/apache/arrow-rs/pull/7771#discussion_r2166457968
##########
arrow-select/src/filter.rs:
##########
@@ -180,25 +180,15 @@ pub fn prep_null_mask_filter(filter: &BooleanArray) ->
BooleanArray {
pub fn filter(values: &dyn Array, predicate: &BooleanArray) ->
Result<ArrayRef, ArrowError> {
let mut filter_builder = FilterBuilder::new(predicate);
- if multiple_arrays(values.data_type()) {
+ if FilterBuilder::multiple_arrays(values.data_type()) {
Review Comment:
The diff makes this PR look like a much larger change than it really is -- I
found using whitespace blind diff was easier to see the changes:
https://github.com/apache/arrow-rs/pull/7771/files?w=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
