zeroshade commented on code in PR #421:
URL: https://github.com/apache/arrow-go/pull/421#discussion_r2167476472
##########
arrow/ipc/ipc.go:
##########
@@ -71,6 +71,7 @@ type config struct {
ensureNativeEndian bool
noAutoSchema bool
emitDictDeltas bool
+ skipEmittingSchema bool
Review Comment:
can we remove this?
##########
arrow/ipc/writer.go:
##########
@@ -91,8 +91,9 @@ type Writer struct {
// map of the last written dictionaries by id
// so we can avoid writing the same dictionary over and over
- lastWrittenDicts map[int64]arrow.Array
- emitDictDeltas bool
+ lastWrittenDicts map[int64]arrow.Array
+ emitDictDeltas bool
+ skipEmittingSchema bool
Review Comment:
Same as above, can we revert the changes for `skipEmittingSchema` since we
are just adding the `WritePayload` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
