hiroyuki-sato opened a new pull request, #46896:
URL: https://github.com/apache/arrow/pull/46896
### Rationale for this change
This is the sub issue #44748.
* SC2046: Quote this to prevent word splitting.
* SC2086: Double quote to prevent globbing and word splitting.
```
shellcheck ci/scripts/install_minio.sh
In ci/scripts/install_minio.sh line 37:
if [ -z ${archs[$arch]} ]; then
^-------------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
Did you mean:
if [ -z "${archs[$arch]}" ]; then
In ci/scripts/install_minio.sh line 74:
mkdir -p $(dirname ${output})
^------------------^ SC2046 (warning): Quote this to prevent word
splitting.
^-------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
mkdir -p $(dirname "${output}")
In ci/scripts/install_minio.sh line 76:
wget -nv --output-document ${output} ${url}
^-------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
Did you mean:
wget -nv --output-document "${output}" "${url}"
In ci/scripts/install_minio.sh line 78:
curl --fail --location --output ${output} ${url}
^-------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^----^ SC2086 (info): Double
quote to prevent globbing and word splitting.
Did you mean:
curl --fail --location --output "${output}" "${url}"
In ci/scripts/install_minio.sh line 85:
download ${prefix}/bin/minio ${url}
^-------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
download "${prefix}"/bin/minio "${url}"
In ci/scripts/install_minio.sh line 86:
chmod +x ${prefix}/bin/minio
^-------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
Did you mean:
chmod +x "${prefix}"/bin/minio
In ci/scripts/install_minio.sh line 91:
download ${prefix}/bin/mc ${url}
^-------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
download "${prefix}"/bin/mc "${url}"
In ci/scripts/install_minio.sh line 92:
chmod +x ${prefix}/bin/mc
^-------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
Did you mean:
chmod +x "${prefix}"/bin/mc
For more information:
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word
splitt...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
```
### What changes are included in this PR?
* Quote variables.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
