alamb commented on code in PR #7782:
URL: https://github.com/apache/arrow-rs/pull/7782#discussion_r2167776667
##########
parquet-variant/src/to_json.rs:
##########
@@ -103,23 +105,34 @@ fn write_decimal_i64(
///
/// # Examples
///
+///
/// ```rust
/// # use parquet_variant::{Variant, variant_to_json};
/// # use arrow_schema::ArrowError;
-/// let variant = Variant::Int32(42);
+/// let variant = Variant::String("Hello, World!");
Review Comment:
I agree. My understanding is that a smaller string for `Variant::Stirng` is
still valid, just less efficient.
Maybe I should update the examples to use `Variant::from` which does the
right thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
