ctsk commented on code in PR #7773:
URL: https://github.com/apache/arrow-rs/pull/7773#discussion_r2173187524
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -736,12 +745,18 @@ where
}
impl<T: ByteViewType + ?Sized> From<GenericByteViewArray<T>> for ArrayData {
- fn from(mut array: GenericByteViewArray<T>) -> Self {
+ fn from(array: GenericByteViewArray<T>) -> Self {
let len = array.len();
- array.buffers.insert(0, array.views.into_inner());
+ let new_buffers = {
Review Comment:
I can reproduce the slowdown for the concat kernel on my laptop.
For this allocation, I believe we in turn save doing this allocation during
`clone()` when using Arc<ViewBuffers>...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
