kou commented on code in PR #428:
URL: https://github.com/apache/arrow-go/pull/428#discussion_r2173525479
##########
internal/hashing/xxh3_memo_table.go:
##########
@@ -97,14 +106,14 @@ const (
loadFactor int64 = 2
)
-func max(a, b uint64) uint64 {
- if a > b {
- return a
- }
- return b
-}
+// func max(a, b uint64) uint64 {
+// if a > b {
+// return a
+// }
+// return b
+// }
-var isNan32Cmp = func(v float32) bool { return math.IsNaN(float64(v)) }
+// var isNan32Cmp = func(v float32) bool { return math.IsNaN(float64(v)) }
Review Comment:
Can we remove them instead of commenting out them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
