andishgar commented on issue #46776: URL: https://github.com/apache/arrow/issues/46776#issuecomment-3018078044
@pitrou Three days after reporting these issues, I unfortunately encountered a problem that prevented me from doing any coding activity for two weeks. I will probably not be able to work on this issue before August 30th. So I’m totally fine if someone else wants to take it over. By the way, I had a chance to look at the arrow::Tensor API, and I think there are several things worth mentioning. 1- `ARROW_PREDICT_FALSE` appears to be appropriate for the following code. https://github.com/apache/arrow/blob/f8cd17c0651e4886a08b2664ec8e0a0fff09eaa2/cpp/src/arrow/tensor.cc#L57 2-The following assertions should use` ASSERT_FLOAT_EQ` instead. https://github.com/apache/arrow/blob/953947a78157090ff94b14bc027cbcf520a5b2a6/cpp/src/arrow/tensor_test.cc#L708-L713 https://github.com/apache/arrow/blob/953947a78157090ff94b14bc027cbcf520a5b2a6/cpp/src/arrow/tensor_test.cc#L747-L752 3- The code below could be split into two separate paths for contiguous and non-contiguous tensors, similar to what's done in [counting zeros](https://github.com/apache/arrow/blob/953947a78157090ff94b14bc027cbcf520a5b2a6/cpp/src/arrow/tensor.cc#L513-L520) . https://github.com/apache/arrow/blob/953947a78157090ff94b14bc027cbcf520a5b2a6/cpp/src/arrow/compare.cc#L1248-L1292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
