rok commented on code in PR #7818:
URL: https://github.com/apache/arrow-rs/pull/7818#discussion_r2174734166
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -141,7 +141,7 @@ pub struct ArrowWriter<W: Write> {
arrow_schema: SchemaRef,
/// Creates new [`ArrowRowGroupWriter`] instances as required
- row_group_writer_factory: ArrowRowGroupWriterFactory,
+ pub row_group_writer_factory: ArrowRowGroupWriterFactory,
Review Comment:
Some of these `pub`s are artifacts of older approaches. Removing.
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -789,44 +790,54 @@ impl ArrowRowGroupWriter {
}
}
-struct ArrowRowGroupWriterFactory {
+/// Factory for creating [`ArrowRowGroupWriter`] instances.
+/// This is used by [`ArrowWriter`] to create row group writers, but can be
used
+/// directly for lower level API.
+pub struct ArrowRowGroupWriterFactory {
#[cfg(feature = "encryption")]
file_encryptor: Option<Arc<FileEncryptor>>,
}
impl ArrowRowGroupWriterFactory {
+ /// Creates a new [`ArrowRowGroupWriterFactory`] using provided
[`SerializedFileWriter`].
#[cfg(feature = "encryption")]
- fn new<W: Write + Send>(file_writer: &SerializedFileWriter<W>) -> Self {
+ pub fn new<W: Write + Send>(file_writer: &SerializedFileWriter<W>) -> Self
{
Self {
file_encryptor: file_writer.file_encryptor(),
}
}
#[cfg(not(feature = "encryption"))]
- fn new<W: Write + Send>(_file_writer: &SerializedFileWriter<W>) -> Self {
+ pub fn new<W: Write + Send>(_file_writer: &SerializedFileWriter<W>) ->
Self {
Self {}
}
+ /// Creates a new [`ArrowRowGroupWriter`] for the given parquet schema and
writer properties.
#[cfg(feature = "encryption")]
- fn create_row_group_writer(
+ pub fn create_row_group_writer(
&self,
parquet: &SchemaDescriptor,
props: &WriterPropertiesPtr,
arrow: &SchemaRef,
row_group_index: usize,
) -> Result<ArrowRowGroupWriter> {
- let writers = get_column_writers_with_encryptor(
- parquet,
- props,
- arrow,
- self.file_encryptor.clone(),
- row_group_index,
- )?;
+ let mut writers = Vec::with_capacity(arrow.fields.len());
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
