scovich commented on code in PR #7809:
URL: https://github.com/apache/arrow-rs/pull/7809#discussion_r2174906878
##########
parquet-variant/src/variant.rs:
##########
@@ -629,6 +638,9 @@ impl<'m, 'v> Variant<'m, 'v> {
Variant::Int16(i) => Some(i.into()),
Variant::Int32(i) => Some(i.into()),
Variant::Int64(i) => Some(i),
+ Variant::Decimal4(d) if d.scale == 0 => Some(d.integer.into()),
+ Variant::Decimal8(d) if d.scale == 0 => Some(d.integer),
+ Variant::Decimal16(d) if d.scale == 0 => d.integer.try_into().ok(),
Review Comment:
This is always tricky -- if we go for Option instead, and convert None to
Err, then the resulting error message contains little or no information about
_why_ the conversion failed. And I don't think we want to duplicate code, to do
both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
