sgrebnov commented on code in PR #2961:
URL: https://github.com/apache/arrow-adbc/pull/2961#discussion_r2175706514
##########
.github/workflows/integration.yml:
##########
@@ -323,3 +323,47 @@ jobs:
run: |
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
env BUILD_DRIVER_MANAGER=0 ./ci/scripts/python_test.sh "$(pwd)"
"$(pwd)/build"
+
+ flightsql_interop:
+ name: "FlightSQL C# Interop"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: Get required Go version
+ run: |
+ (. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
+
+ - name: Get Date
+ id: get-date
+ run: |
+ echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
+
+ - uses: actions/setup-go@v5
+ with:
+ go-version: "${{ env.GO_VERSION }}"
+ check-latest: true
+ cache: true
+ cache-dependency-path: go/adbc/go.sum
+
+ - name: Build ADBC Driver
+ working-directory: go/adbc/pkg
+ run: |
+ make libadbc_driver_flightsql.so
+ ls -l
+
+ - name: Start Test Servers
+ run: |
+ docker compose up --wait --detach spiceai-test
+
+ - name: Test Driver against Spice.ai OSS
Review Comment:
The main motivation for adding this test separately was to provide better
isolation, readability, and control over the C# Interop FlightSQL tests, as
well as to make it easier to extend the tests with additional targets such as
Dremio, DuckDB, and others.
@lidavidm - please confirm if you would prefer to move this test into the
existing FlightSQL test pipeline. If so, I’ll just add the additional test step
as `Test FlightSQL C# Interop Driver against Spice.ai`
The test itself takes approximately 70 seconds (building the ADBC Go driver,
running the test server, and executing the tests).
https://github.com/apache/arrow-adbc/actions/runs/15980905994/job/45074830754?pr=2961
<img width="856" alt="image"
src="https://github.com/user-attachments/assets/806059af-683c-42cd-8fbe-c05c9671c380";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
