westonpace commented on pull request #9941: URL: https://github.com/apache/arrow/pull/9941#issuecomment-816849479
I'm not too sure what to do about the remaining complexity. I could change the background thread so it blocks instead of releasing the thread although I think that would introduce the need for a proper condition variable. I could change the polling thread so that a restart that is blocked by a cleaning up background thread blocks instead of using callbacks. But then this is blocking in an async context which is ideally avoided. Or we could simply go back to the old method of thread task per request. At the end of the day the threads were only adding a small overhead to the cached I/O case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
