nealrichardson commented on a change in pull request #9950:
URL: https://github.com/apache/arrow/pull/9950#discussion_r610809769
##########
File path: r/src/json.cpp
##########
@@ -31,14 +31,24 @@ std::shared_ptr<arrow::json::ReadOptions>
json___ReadOptions__initialize(bool us
}
// [[arrow::export]]
-std::shared_ptr<arrow::json::ParseOptions> json___ParseOptions__initialize(
+std::shared_ptr<arrow::json::ParseOptions> json___ParseOptions__initialize1(
bool newlines_in_values) {
auto res =
std::make_shared<arrow::json::ParseOptions>(arrow::json::ParseOptions::Defaults());
res->newlines_in_values = newlines_in_values;
return res;
}
+// [[arrow::export]]
+std::shared_ptr<arrow::json::ParseOptions> json___ParseOptions__initialize2(
+ bool newlines_in_values, const std::shared_ptr<arrow::Schema>&
explicit_schema) {
+ auto res =
+
std::make_shared<arrow::json::ParseOptions>(arrow::json::ParseOptions::Defaults());
+ res->newlines_in_values = newlines_in_values;
+ res->explicit_schema = explicit_schema;
+ return res;
+}
+
Review comment:
My bad, I thought I saw that you copied it from the other function
(because I noticed the `TODO(fsaintjacques)` duplicated in the diff) but maybe
it was just next to what you were doing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
