pitrou commented on code in PR #46755:
URL: https://github.com/apache/arrow/pull/46755#discussion_r2176491669
##########
python/pyarrow/config.pxi:
##########
@@ -77,6 +78,27 @@ def runtime_info():
detected_simd_level=frombytes(c_info.detected_simd_level))
+PythonBuildInfo = namedtuple(
Review Comment:
Suggestion:
1. rename the `BuildInfo` class above to `CppBuildInfo`
2. rename this `PythonBuildInfo` class to `BuildInfo`
3. add the `CppBuildInfo` as an attribute of `BuildInfo`
##########
python/pyarrow/tests/test_misc.py:
##########
@@ -94,6 +94,10 @@ def test_build_info():
assert pa.cpp_build_info.build_type in (
'debug', 'release', 'minsizerel', 'relwithdebinfo')
+ assert isinstance(pa.build_info(), pa.PythonBuildInfo)
Review Comment:
Ah, I realize that `pa.cpp_build_info` is a simple attribute, not a
function, so perhaps `pa.build_info` should be made an attribute as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
