kszucs commented on PR #45089: URL: https://github.com/apache/arrow/pull/45089#issuecomment-3022314517
> Thanks @kszucs . LGTM in general but two suggestions: > > 1. Can you update the docs in https://arrow.apache.org/docs/python/filesystems.html#using-fsspec-compatible-filesystems-with-arrow ? Yes, updating. > 2. Can you perhaps add a non-Parquet-focussed test in `test_fs.py`? `FileSystem.from_uri()` is a lower level construct than the factory functions we have in `fs.py` so I could only test the protected functions defined in `fs.py` for now. Ideally we should consolidate the logic so that `FileSystem.from_uri` become self-contained. I can tackle that in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
