pitrou commented on PR #46926: URL: https://github.com/apache/arrow/pull/46926#issuecomment-3023030804
Hi @Taepper , thanks for submitting this. Design-wise, I think there are two possible APIs here: 1) (As done in this PR) Add a required `NullPlacement` in `SortKey`, and make the `NullPlacement` in `SortOptions` optional and deprecated 2) Add an optional `NullPlacement` in `SortKey`, and keep the required `NullPlacement` in `SortOptions` as fallback Option 1 has the advantage that it's conceptually simpler once the deprecation period is over, but it comes with a minor API change and a slightly complicated deprecation period. Option 2 is conceptually a bit more complicated (per-key + global fallback) but avoids breaking the current API and doesn't introduce any deprecation. I'm not sure which one is better. @zanmato1984 @felipecrv Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
