alamb commented on code in PR #7832:
URL: https://github.com/apache/arrow-rs/pull/7832#discussion_r2177268965
##########
arrow-avro/src/reader/record.rs:
##########
@@ -732,4 +838,122 @@ mod tests {
assert_eq!(list_arr.len(), 1);
assert_eq!(list_arr.value_length(0), 0);
}
+
+ #[test]
+ fn test_decimal_decoding_fixed256() {
Review Comment:
I don't really have any way to verify that this is doing the right thing
(like I don't know / have any way to verify if `row1` and `row2` byte arrays
are valid avro)
One thing I suggest (in a different PR) is starting to test that the reader
will work "end to end". Specifically, at least these two cases:
1. Testing reading avro files written with other implementations
2. Test "round tripping" arrow data from Arrow --> Avro --> Arrow and
ensuring the same data has arrived
@jecsand838 have you considered this type of testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
