rich-t-kid-datadog commented on code in PR #7713:
URL: https://github.com/apache/arrow-rs/pull/7713#discussion_r2178245751
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -137,6 +139,10 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
can_cast_types(from_value_type, to_value_type)
}
(Dictionary(_, value_type), _) => can_cast_types(value_type, to_type),
+ (RunEndEncoded(_, value_type), _) =>
can_cast_types(value_type.data_type(), to_type),
+ (_, RunEndEncoded(_, _value_type)) => true,
Review Comment:
Yes, for datatypes such as dictionarys there isnt a valid way to encode
these as REE. Ive updated this to focus on in built datatypes
(numeric,strings,REE) and if theres one that I missed it should be more correct
to add to the match expression than hardcoding true in the `mod.rs` file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
