alamb commented on code in PR #7783:
URL: https://github.com/apache/arrow-rs/pull/7783#discussion_r2178455887
##########
parquet-variant/src/variant/decimal.rs:
##########
@@ -65,6 +65,12 @@ macro_rules! format_decimal {
}};
}
+// Common trait to classify VariantDecimalXXX types
+pub trait VariantDecimal {
+ fn integer(&self) -> i128;
Review Comment:
I agree -- when I was playing around with this, I am convinced that a custom
decimal parser from `&str` is the way to go. That way we won't have to
artifically use i128 -- the code can look at the `&str` instead and figure out
how what decimal size it needs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
