crepererum commented on code in PR #422:
URL:
https://github.com/apache/arrow-rs-object-store/pull/422#discussion_r2179880410
##########
src/client/retry.rs:
##########
@@ -32,7 +32,7 @@ use tracing::info;
use web_time::{Duration, Instant};
/// Retry request error
-#[derive(Debug, thiserror::Error)]
+#[derive(Debug)]
Review Comment:
I disagree because:
1. this type isn't public, hence it can only be used as via the trait `dyn
Error`. You CANNOT downcast it.
2. All this derive does is to implement `std::error::Error`. Also see
[thiserror docs](https://docs.rs/thiserror/latest/thiserror/#details) that
state "Thiserror deliberately does not appear in your public API." I.e.
removing this is a change of an implementation detail, NOT a public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
