wgtmac commented on code in PR #46932:
URL: https://github.com/apache/arrow/pull/46932#discussion_r2182336561
##########
cpp/examples/arrow/parquet_read_write.cc:
##########
@@ -66,7 +66,7 @@ arrow::Status ReadInBatches(std::string path_to_file) {
std::unique_ptr<parquet::arrow::FileReader> arrow_reader;
ARROW_ASSIGN_OR_RAISE(arrow_reader, reader_builder.Build());
- std::shared_ptr<::arrow::RecordBatchReader> rb_reader;
+ std::unique_ptr<::arrow::RecordBatchReader> rb_reader;
Review Comment:
We don't need to change this, right?
##########
cpp/src/parquet/arrow/reader.h:
##########
@@ -191,11 +191,19 @@ class PARQUET_EXPORT FileReader {
///
/// \returns error Status if either row_group_indices or column_indices
/// contains an invalid index
+ /// \deprecated Deprecated in 20.0.0. Use arrow::Result version instead.
Review Comment:
It should be 21.0.0 (if we can merge this before the code freeze; otherwise
22.0.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
