scovich commented on issue #7870:
URL: https://github.com/apache/arrow-rs/issues/7870#issuecomment-3037238163

   It almost seems like the top-level `VariantBuilder` shouldn't even exist:
   * For any primitive value, `Variant::from` the input should work
   * For list and object values, perhaps we need a way to construct a list or 
object builder directly
   
   The one thing `VariantBuilder` _does_ provide is the handling of separate 
metadata + value buffers. But that just proves the current "append as many 
values as you like" API is incorrect -- each top-level variant value in a 
column of variant values needs its own metadata value -- not one aggregate 
metadata value for the whole column.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to