zhuqi-lucas commented on PR #7875: URL: https://github.com/apache/arrow-rs/pull/7875#issuecomment-3041731813
Thank you @alamb for benchmark, i think it's ok for the benchmark here, only less than 10% for some cases: ```rust sort string_view[0-400] nulls to indices 2^12 1.04 89.2±0.16µs ? ?/sec 1.00 85.4±0.13µs ? ?/sec sort string_view[0-400] to indices 2^12 1.10 133.6±0.21µs ? ?/sec 1.00 121.6±0.22µs ? ?/sec sort string_view[10] nulls to indices 2^12 1.05 73.7±0.38µs ? ?/sec 1.00 70.5±0.55µs ? ?/sec sort string_view[10] to indices 2^12 1.00 104.2±0.46µs ? ?/sec 1.00 104.4±0.25µs ? ?/sec sort string_view_inlined[0-12] nulls to indices 2^12 1.06 70.7±0.28µs ? ?/sec 1.00 66.6±0.26µs ? ?/sec sort string_view_inlined[0-12] to indices 2^12 1.00 94.5±0.25µs ? ?/sec 1.01 95.0±1.10µs ? ?/sec ``` Because we originally has improved the sort with main for total 2x ~5x faster for the following two PRs: https://github.com/apache/arrow-rs/pull/7792 https://github.com/apache/arrow-rs/pull/7856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org