felipecrv commented on code in PR #3108: URL: https://github.com/apache/arrow-adbc/pull/3108#discussion_r2190774782
########## go/adbc/pkg/Makefile: ########## @@ -28,17 +31,18 @@ endif GIT_VERSION=$(shell git tag -l --points-at $(shell git rev-list --tags --max-count=1) --sort=-v:refname | head -n 1) VERSION=$(subst go/adbc/,,$(GIT_VERSION)) -DRIVERS := \ - libadbc_driver_bigquery.$(SUFFIX) \ - libadbc_driver_flightsql.$(SUFFIX) \ - libadbc_driver_panicdummy.$(SUFFIX) \ - libadbc_driver_snowflake.$(SUFFIX) +# Expand dynamically libadbc_driver_.SUFFIX +DRIVERS := $(addsuffix .$(SUFFIX),$(addprefix libadbc_driver_,$(MANAGERS))) Review Comment: magic ✨ ########## go/adbc/pkg/Makefile: ########## @@ -14,8 +14,11 @@ # See the License for the specific language governing permissions and # limitations under the License. -GO_BUILD=go build -RM=rm -f +MANAGERS = bigquery flightsql panicdummy snowflake Review Comment: as in Database MANAGEMENT Systems? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
