friendlymatthew commented on code in PR #7878:
URL: https://github.com/apache/arrow-rs/pull/7878#discussion_r2190999047
##########
parquet-variant/src/variant/metadata.rs:
##########
@@ -230,7 +227,98 @@ impl<'m> VariantMetadata<'m> {
if !self.validated {
// Iterate over all string keys in this dictionary in order to
prove that the offset
// array is valid, all offsets are in bounds, and all string bytes
are valid utf-8.
- validate_fallible_iterator(self.iter_try())?;
+
+ /*
+ As scovich pointed out, here are the things full validation must
do:
Review Comment:
Haha, yes. Fwiw, these comments are strictly for reviewers. This first pass
was to ensure the proposed change was directionally sound
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
