alamb commented on code in PR #7873:
URL: https://github.com/apache/arrow-rs/pull/7873#discussion_r2192438208
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -473,13 +473,85 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
/// Note: this function does not attempt to canonicalize / deduplicate
values. For this
/// feature see [`GenericByteViewBuilder::with_deduplicate_strings`].
pub fn gc(&self) -> Self {
- let mut builder =
GenericByteViewBuilder::<T>::with_capacity(self.len());
+ // 1) Read basic properties once
Review Comment:
There are some good tricks here that maybe we can apply to `coalese` -- in
https://github.com/apache/arrow-rs/blob/38a7a1a6f11cc3bcad7174675de82cbd99067cb6/arrow-select/src/coalesce/byte_view.rs#L114
The only difference is the ability to extend exsiting views/buffers rather
than allocate entirely new buffers 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
