pitrou commented on code in PR #46992:
URL: https://github.com/apache/arrow/pull/46992#discussion_r2192895147
##########
cpp/src/parquet/statistics_test.cc:
##########
@@ -693,6 +697,8 @@ class TestStatisticsHasFlag : public
TestStatistics<TestType> {
EXPECT_FALSE(statistics1->HasMinMax());
EXPECT_FALSE(encoded_stats1.has_min);
EXPECT_FALSE(encoded_stats1.has_max);
+ EXPECT_FALSE(encoded_stats1.is_min_value_exact);
+ EXPECT_FALSE(encoded_stats1.is_max_value_exact);
Review Comment:
Don't you want to test `has_value()` explicitly? Or perhaps change this to:
```suggestion
EXPECT_EQ(encoded_stats1.is_max_value_exact, std::nullopt);
```
(assuming that works)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
