projjal commented on a change in pull request #9974:
URL: https://github.com/apache/arrow/pull/9974#discussion_r611355614
##########
File path: cpp/src/gandiva/precompiled/types.h
##########
@@ -251,6 +251,7 @@ gdv_timestamp castTIMESTAMP_utf8(int64_t execution_context,
const char* input,
gdv_timestamp castTIMESTAMP_date64(gdv_date64);
gdv_timestamp castTIMESTAMP_int64(gdv_int64);
gdv_date64 castDATE_timestamp(gdv_timestamp);
+int32_t castTIME_timestamp(int64_t timestamp_in_millis);
Review comment:
when you are referring to time and timestamp its more clear to use the
aliases gdv_time & gdv_timestamp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
