lidavidm commented on code in PR #3124:
URL: https://github.com/apache/arrow-adbc/pull/3124#discussion_r2196194545
##########
go/adbc/pkg/Makefile:
##########
@@ -21,14 +21,16 @@ RM := rm -f
ifeq ($(shell go env GOOS),linux)
SUFFIX=so
+ GIT_VERSION=$(shell git tag --sort=-v:refname --points-at $(shell git
rev-list --tags --max-count=1 2>/dev/null) 2>/dev/null | head -n 1)
else ifeq ($(shell go env GOOS),windows)
SUFFIX=dll
RM=del
+ GIT_VERSION=$(shell powershell -Command "git tag --sort=-v:refname
--points-at $(git rev-list --tags --max-count=1) | Select-Object -First 1")
else
SUFFIX=dylib
Review Comment:
Doesn't this omit macOS? Maybe there should be a separate `ifeq windows
[powershell] else [git]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
