lidavidm commented on a change in pull request #9966:
URL: https://github.com/apache/arrow/pull/9966#discussion_r611594814



##########
File path: python/pyarrow/tests/parquet/test_dataset.py
##########
@@ -972,6 +972,10 @@ def test_dataset_read_pandas(tempdir, use_legacy_dataset):
 
     tm.assert_frame_equal(result, expected)
 
+    # also be able to pass the columns as a set (ARROW-12314)
+    result = dataset.read_pandas(columns=set(columns)).to_pandas()
+    tm.assert_frame_equal(result, expected)

Review comment:
       It looks like this test needs to account for column order potentially 
being different, since sets (surprisingly?) didn't get deterministic ordering 
like dictionaries did.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to