jackyhu-db opened a new pull request, #3131:
URL: https://github.com/apache/arrow-adbc/pull/3131

   ## Motivation 
   
   The default value of `GetObjectsPatternsRequireLowerCase` of 
`DatabricksConnection` is `false` (inherit from `SparkConnection`, see 
[here](https://github.com/apache/arrow-adbc/blob/main/csharp/src/Drivers/Apache/Spark/SparkConnection.cs#L116)),
 so when it is called with table pattern in uppercase as below, it does not 
return all the tables start with `test` and fails some test cases 
[DriverTest:GetObjectsTablesTest](https://github.com/apache/arrow-adbc/blob/main/csharp/test/Drivers/Apache/Common/DriverTests.cs#L308)
 (when `tableNamePattern` is uppercase)
   
   ```
   Connection.GetObjects(
                       depth: AdbcConnection.GetObjectsDepth.Tables,
                       catalogPattern = "catalog1",
                       dbSchemaPattern = "default",
                       tableNamePattern = "TEST%");
   ```
   
   ## Changes
   - Override `GetObjectsPatternsRequireLowerCase` to `true` in 
`DatabricksConnection`
   
   ## Test
   Apache.Arrow.Adbc.Tests.Drivers.Databricks.DriverTests.CanGetObjectsTables
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to