MichaelScofield commented on code in PR #7839:
URL: https://github.com/apache/arrow-rs/pull/7839#discussion_r2199335122
##########
arrow-flight/examples/flight_sql_server.rs:
##########
@@ -814,7 +814,7 @@ mod tests {
async fn bind_tcp() -> (TcpIncoming, SocketAddr) {
let listener = TcpListener::bind("0.0.0.0:0").await.unwrap();
let addr = listener.local_addr().unwrap();
- let incoming = TcpIncoming::from_listener(listener, true,
None).unwrap();
+ let incoming = TcpIncoming::from(listener);
Review Comment:
Previously the `TcpIncoming` in tonic 0.12 the `nodelay` was explicitly set
to true; however, here the default is `None`. Maybe it's better to align the
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
