emkornfield opened a new issue, #7909:
URL: https://github.com/apache/arrow-rs/issues/7909

   **Describe the bug**
   
   The [current reader 
code](https://github.com/apache/arrow-rs/blob/1b8cd9ace2e746a073ee7204db5d0d0cfec67d31/parquet/src/file/metadata/reader.rs#L1046C20-L1055C22)
 for interpreting sort orders, does not appear to push back any elements into 
the Vec if the sort order does not match `TYPEORDER`.  If this is correct 
reading (not very familiar with Rust).  Then for any new sort orders added 
there is likely going to be a panic or error when trying to make use of the 
returned vector.
   
   **To Reproduce**
   
   N/A, this is from code inspection.
   
   **Expected behavior**
   
   When an unmatched sort order is encountered UNKNOWN/Undefined sort order is 
pushed back
   
   **Additional context**
   
   I was reading this code in the context of how to handle recent discussions 
around defining int96 sort order in the specification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to