assignUser commented on code in PR #47082:
URL: https://github.com/apache/arrow/pull/47082#discussion_r2202058297
##########
dev/release/verify-release-candidate.sh:
##########
@@ -789,14 +789,29 @@ ensure_source_directory() {
if [ ! -d "${ARROW_SOURCE_DIR}" ]; then
pushd $ARROW_TMPDIR
fetch_archive ${dist_name}
- git clone https://github.com/${GITHUB_REPOSITORY}.git arrow
- pushd arrow
- dev/release/utils-create-release-tarball.sh ${VERSION} ${RC_NUMBER}
- if ! cmp ${dist_name}.tar.gz ../${dist_name}.tar.gz; then
- echo "Source archive isn't reproducible"
- return 1
+ verify_reproducible_build=true
+ if [ "${GITHUB_ACTIONS}" != "true" ]; then
+ verify_reproducible_build=false
+ fi
+ # We need GNU tar to verify reproducible build
+ if ! tar --version | grep --quiet --fixed GNU || \
+ ! gtar --version | grep --quiet --fixed GNU; then
+ verify_reproducible_build=false
+ fi
+ # We need GNU gzip to verify reproducible build
+ if ! gzip --version | grep --quiet --fixed GNU; then
+ verify_reproducible_build=false
+ fi
+ if [ "${verify_reproducible_build}" = "true" ]; then
+ git clone https://github.com/${GITHUB_REPOSITORY}.git arrow
Review Comment:
That would probably cause issues because the tarball script uses tags that
are not fetched on a shallow clone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
