XiangpengHao commented on code in PR #7918:
URL: https://github.com/apache/arrow-rs/pull/7918#discussion_r2202783668
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -469,10 +469,10 @@ pub(crate) fn decode_page(
enum SerializedPageReaderState {
Values {
/// The current byte offset in the reader
- offset: usize,
+ offset: u64,
/// The length of the chunk in bytes
Review Comment:
```suggestion
/// The length of the chunk in bytes
/// Note that remaining_bytes is u64 (i.e., not usize) to support
32-bit architectures such as WASM
```
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -469,10 +469,10 @@ pub(crate) fn decode_page(
enum SerializedPageReaderState {
Values {
/// The current byte offset in the reader
Review Comment:
```suggestion
/// The current byte offset in the reader
/// Note that offset is u64 (i.e., not usize) to support 32-bit
architectures such as WASM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
