domoritz commented on a change in pull request #9961:
URL: https://github.com/apache/arrow/pull/9961#discussion_r611794871
##########
File path: js/gulpfile.js
##########
@@ -56,13 +56,13 @@ knownTargets.forEach((target) => {
));
});
-// The main "apache-arrow" module builds the es5/umd, esnext/cjs,
+// The main "apache-arrow" module builds the es2015/umd, esnext/cjs,
// esnext/esm, and esnext/umd targets, then copies and renames the
// compiled output into the apache-arrow folder
gulp.task(`build:${npmPkgName}`,
gulp.series(
gulp.parallel(
- `build:${taskName(`es5`, `umd`)}`,
+ `build:${taskName(`es2015`, `umd`)}`,
Review comment:
@trxcllnt I was hoping this would be the main thing to do but the bundle
isn't right.
Why is there no es2015 bundle? Why is there an externs file for es5?
<img width="368" alt="Screen Shot 2021-04-12 at 09 48 01"
src="https://user-images.githubusercontent.com/589034/114431287-2d182200-9b74-11eb-8b8c-341e7cff8d94.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/589034/114431287-2d182200-9b74-11eb-8b8c-341e7cff8d94.png"](https://user-images.githubusercontent.com/589034/114431287-2d182200-9b74-11eb-8b8c-341e7cff8d94.png"){kind=link}