ianmcook commented on a change in pull request #9977:
URL: https://github.com/apache/arrow/pull/9977#discussion_r611803944
##########
File path: cpp/cmake_modules/FindgRPCAlt.cmake
##########
@@ -24,222 +24,57 @@ if(gRPC_FOUND)
return()
endif()
-unset(GRPC_ALT_VERSION)
-
-if(ARROW_GRPC_USE_SHARED)
- set(GRPC_GPR_LIB_NAMES)
- set(GRPC_GRPC_LIB_NAMES)
- set(GRPC_GRPCPP_LIB_NAMES)
- set(GRPC_ADDRESS_SORTING_LIB_NAMES)
- set(GRPC_UPB_LIB_NAMES)
- if(CMAKE_IMPORT_LIBRARY_SUFFIX)
- list(APPEND GRPC_GPR_LIB_NAMES
-
"${CMAKE_IMPORT_LIBRARY_PREFIX}gpr${CMAKE_IMPORT_LIBRARY_SUFFIX}")
- list(APPEND GRPC_GRPC_LIB_NAMES
-
"${CMAKE_IMPORT_LIBRARY_PREFIX}grpc${CMAKE_IMPORT_LIBRARY_SUFFIX}")
- list(APPEND GRPC_GRPCPP_LIB_NAMES
-
"${CMAKE_IMPORT_LIBRARY_PREFIX}grpc++${CMAKE_IMPORT_LIBRARY_SUFFIX}")
- list(
- APPEND GRPC_ADDRESS_SORTING_LIB_NAMES
-
"${CMAKE_IMPORT_LIBRARY_PREFIX}address_sorting${CMAKE_IMPORT_LIBRARY_SUFFIX}"
- )
- list(APPEND GRPC_UPB_LIB_NAMES
-
"${CMAKE_IMPORT_LIBRARY_PREFIX}upb${CMAKE_IMPORT_LIBRARY_SUFFIX}")
+find_package(PkgConfig QUIET)
+pkg_check_modules(GRPCPP_PC grpc++)
+if(GRPCPP_PC_FOUND)
+ set(gRPCAlt_VERSION "${GRPCPP_PC_VERSION}")
+ set(GRPCPP_INCLUDE_DIRECTORIES ${GRPCPP_PC_INCLUDEDIR})
+ if(ARROW_GRPC_USE_SHARED)
+ set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES})
+ set(GRPCPP_LINK_OPTIONS ${GRPCPP_PC_LDFLAGS_OTHER})
+ set(GRPCPP_COMPILE_OPTIONS ${GRPCPP_PC_CFLAGS_OTHER})
+ else()
+ set(GRPCPP_LINK_LIBRARIES)
+ foreach(GRPCPP_LIBRARY_NAME ${GRPCPP_PC_STATIC_LIBRARIES})
Review comment:
Should there be an assertion here to check that the required libraries
are in `GRPCPP_PC_STATIC_LIBRARIES` before iterating over them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
