friendlymatthew commented on code in PR #7896:
URL: https://github.com/apache/arrow-rs/pull/7896#discussion_r2203451761
##########
parquet-variant/src/variant/object.rs:
##########
@@ -618,4 +620,112 @@ mod tests {
ArrowError::InvalidArgumentError(ref msg) if msg.contains("Tried
to extract byte(s) ..16 from 15-byte buffer")
));
}
+
+ fn test_variant_object_with_count(count: i32, expected_field_id_size:
OffsetSizeBytes) {
+ let mut builder = VariantBuilder::new();
+ let mut obj = builder.new_object();
+ for val in 0..count {
+ let key = format!("id_{}", val);
+ obj.insert(&key, val);
+ }
+
+ obj.finish().unwrap();
+ let (metadata, value) = builder.finish();
+ let variant = Variant::try_new(&metadata, &value).unwrap();
Review Comment:
Using the builder already does validation, so we can save a lot of time by
doing unchecked validation when reconstructing the variant.
Something like:
```rs
let variant = Variant::new(&metadata, &value);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
